fix some errors
This commit is contained in:
8
.github/workflows/security.yml
vendored
8
.github/workflows/security.yml
vendored
@@ -26,13 +26,13 @@ jobs:
|
|||||||
uses: actions/setup-node@v4
|
uses: actions/setup-node@v4
|
||||||
with:
|
with:
|
||||||
node-version: '18'
|
node-version: '18'
|
||||||
cache: 'npm'
|
cache: 'yarn'
|
||||||
|
|
||||||
- name: Install dependencies
|
- name: Install dependencies
|
||||||
run: npm ci
|
run: yarn install --frozen-lockfile
|
||||||
|
|
||||||
- name: Run npm audit
|
- name: Run yarn audit
|
||||||
run: npm audit --audit-level=high
|
run: yarn audit --level high
|
||||||
|
|
||||||
- name: Initialize CodeQL
|
- name: Initialize CodeQL
|
||||||
uses: github/codeql-action/init@v3
|
uses: github/codeql-action/init@v3
|
||||||
|
|||||||
26
.serena/memories/dashboard_security_fix.md
Normal file
26
.serena/memories/dashboard_security_fix.md
Normal file
@@ -0,0 +1,26 @@
|
|||||||
|
# Dashboard Security Fix
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
The Traefik dashboard at http://quixy.uk:8080/dashboard/#/ was not password protected, showing all requests publicly.
|
||||||
|
|
||||||
|
## Root Cause
|
||||||
|
Two configuration files had `insecure: true` settings that disabled authentication:
|
||||||
|
1. `docker-compose.yml` - `--api.insecure=true` command argument
|
||||||
|
2. `traefik.yml` - `insecure: true` in api section
|
||||||
|
|
||||||
|
## Solution Applied
|
||||||
|
Fixed both configuration files:
|
||||||
|
- Changed `--api.insecure=true` to `--api.insecure=false` in docker-compose.yml
|
||||||
|
- Changed `insecure: true` to `insecure: false` in traefik.yml
|
||||||
|
|
||||||
|
## Authentication Details
|
||||||
|
Dashboard now uses basic HTTP authentication with credentials already configured:
|
||||||
|
- Username: admin
|
||||||
|
- Password: password (hash stored in TRAEFIK_AUTH environment variable)
|
||||||
|
|
||||||
|
## To Apply Changes
|
||||||
|
Run: `docker-compose down && docker-compose up -d`
|
||||||
|
|
||||||
|
## Files Modified
|
||||||
|
- docker-compose.yml:25 (insecure flag)
|
||||||
|
- traefik.yml:18 (insecure setting)
|
||||||
@@ -6,7 +6,7 @@ services:
|
|||||||
restart: unless-stopped
|
restart: unless-stopped
|
||||||
command:
|
command:
|
||||||
- --api.dashboard=true
|
- --api.dashboard=true
|
||||||
- --api.insecure=true
|
- --api.insecure=false
|
||||||
- --providers.docker=true
|
- --providers.docker=true
|
||||||
- --providers.docker.exposedbydefault=false
|
- --providers.docker.exposedbydefault=false
|
||||||
- --entrypoints.web.address=:80
|
- --entrypoints.web.address=:80
|
||||||
|
|||||||
@@ -19,7 +19,7 @@ entryPoints:
|
|||||||
# API and dashboard configuration
|
# API and dashboard configuration
|
||||||
api:
|
api:
|
||||||
dashboard: true
|
dashboard: true
|
||||||
insecure: true
|
insecure: false
|
||||||
|
|
||||||
# Providers configuration
|
# Providers configuration
|
||||||
providers:
|
providers:
|
||||||
|
|||||||
Reference in New Issue
Block a user